Allow jupyterlab v4 in dependency constraints #3028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthiboust
requested review from
T4rk1n,
alexcjohnson,
emilykl,
gvwilson and
ndrezn
as code owners
This was referenced Oct 8, 2024
gvwilson
added
feature
Contributor
|
@marthacryan @T4rk1n does this overlap with ongoing work in Plotly.py / Plotly.js on Jupyter support? |
Contributor
|
@gvwilson No, this is for fixing @mthiboust Look like there is some conflict with the new version and typescript, try updating typescript in the devDependencies. |
Contributor
Author
@T4rk1n Should be ok now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2804 and #2998
The current
dashextension forjupyterlabcannot be installed withjupyerlab v4. In practice, it means that the backend is not able to communicate with the juperlab frontend to retrieve the base URL when using thejupyter_dash.infer_jupyter_proxy_config()method. I made it work by simply changing the dependency constraints and it is now working.