-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add R build test to CircleCI #1238
Conversation
* wrap descriptions at 60 chars * fix wildcard handling * support for non-CSS/JS deps in assets * add value tag for .Rd files * add copyright field to DESCRIPTION * add Authors@R line to DESCRIPTION * fix --r-suggests lstrip bug * +sp after , if missing in R imp/sugg/deps
@alexcjohnson @Marc-Andre-Rivet |
.circleci/config.yml
Outdated
git clone --depth 1 https://github.com/plotly/dashR.git -b dev dashR | ||
git clone --depth 1 https://github.com/plotly/dash-html-components.git -b dev | ||
git clone --depth 1 https://github.com/plotly/dash-core-components.git -b dev | ||
git clone --depth 1 https://github.com/plotly/dash-table.git -b dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for -b dev
as the default branch is dev
for html/dcc/table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 74083ce
dcc has a similar test job structure and only has one percy build per commit. The only difference I see is the env var
|
Apparently this tells Percy we're not sure how many parallel threads this run will have, but we're done when the orb sends I'm not sure what that means, since whenever I hear "orb" I think Little Fluffy Clouds. Should we modify this setting? Is Percy not reporting the finalized state consistently? |
|
This PR proposes a set of tests to assess the health of the entire Dash component library build pipeline for R, as we currently do with Dash for Python.
There have been a few instances of package builds in the past using
dash-generate-components
which appeared to succeed, but failed to install or work properly due to minor misconfiguration issues. A build test would help identify these inconsistencies prior to a Dash release.Late last year, @Marc-Andre-Rivet described a desirable workflow for testing R builds upon pushing to
dev
:dev
branchesdashr-on-premise-sample-app
is functional and interactive (such a test is proposed in Add dopsa test for proposed R build test dashR#199)I suggest adding the following integrity checks to the above list:
R CMD build
to ensure that packages are properly formatted, can be built into tarballs, and are ready forR CMD check
R CMD check --as-cran --no-manual
to ensure that changes have not violated CRAN requirementsThe current draft appears to work generally as intended.
@Marc-Andre-Rivet @alexcjohnson @josegonzalez