Skip to content

Extract graph schema validation into properly named test #3735

Open

Description

@T4rk1n

In test: test_tagr002_tabs_render_without_selected we do

    # do some extra tests while we're here
    # and have access to Graph and plotly.js
    check_graph_config_shape(dash_dcc)

This check that we have all the props defined, but the test is random and parametrized so the same check is run twice. It should be in it's own test.

Activity

  1. siva1104 commented on Jun 6, 2026

    @siva1104

    Hi @T4rk1n 👋
    I'd like to work on this issue! I understand the fix involves extracting check_graph_config_shape(dash_dcc) into its own dedicated test. Is this still available to work on?
    Starting on it now!

  2. siva1104 commented on Jun 6, 2026

    @siva1104

    Hi! I'm looking into this issue.

    While investigating, I noticed that the referenced code (check_graph_config_shape) appears to have been removed in PR #3737 ("Add displayNotifier to Graph config props"). I can't find the helper or its invocation in the current dev branch.

    Is there a current location where this validation still exists, or has the issue effectively been resolved by subsequent changes?

  3. T4rk1n commented on Jul 8, 2026

    @T4rk1n
    ContributorAuthor

    Hi! I'm looking into this issue.

    While investigating, I noticed that the referenced code (check_graph_config_shape) appears to have been removed in PR #3737 ("Add displayNotifier to Graph config props"). I can't find the helper or its invocation in the current dev branch.

    Is there a current location where this validation still exists, or has the issue effectively been resolved by subsequent changes?

    The test was removed since it was in another tests, the idea was to take the assertion removed in #3737 and make it's own tests and fix the new config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions