Removed deprecated dependencies that are now integrated#69
Removed deprecated dependencies that are now integrated#69Lew-Goldstein wants to merge 1 commit intoplotly:masterfrom
Conversation
dash_bootstrap_components, dash_html_components, and dash.dependencies are now integrated into core dash, so modified Import statements to reflect this change.
jourdain
left a comment
There was a problem hiding this comment.
Rather than commenting then, I would remove the lines unless you want to add a comment stating this is for dash<=version
There was a problem hiding this comment.
Is it worth writing an import that supports various versions, like:
import dash
if hasattr(dash, "html"):
html = dash.html
else:
import dash_html_components as htmlto catch dcc/Input/Output/... if users are running this on Dash < 2.0.0, or should we expect only >2.0 to be using these examples?
|
For demos/examples, at this point I think assuming Dash 2.x is fine. If these imports were inside the package though we'd definitely still want 1.x fallbacks. |
| import dash | ||
| from dash import dcc, html, Input, Output |
There was a problem hiding this comment.
Nonblocking, but some styleguides/linters complain that this is a duplicate import. This is why most of our examples now explicitly import everything you're going to use - in this case that would add Dash and no_update which then lose the dash. prefix below - so you can drop the plain import dash.
dash_bootstrap_components, dash_html_components, and dash.dependencies are now integrated into core dash, so modified Import statements to reflect this change in the demo app.
About
Description of changes
Pre-Merge checklist
npm run build.Reference Issues
Closes #[issue number]
Other comments