This repository was archived by the owner on Aug 29, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 72
Issue 188 - Simpler multiline / ellipsis #573
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove unused styling code - update changelog
Marc-Andre-Rivet
commented
Sep 5, 2019
| return typeof dimension === 'string' && | ||
| /^\d+(\.\d+)?(px|em|rem|%)$/.test(dimension); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stumbled upon this code. It isn't used anymore. Removing.
Collaborator
|
Simpler is nice, but the remaining percy diffs look problematic and in the matching docs PR I don't see ellipsis https://dash-docs-pr-642.herokuapp.com/datatable/sizing |
Contributor
Author
|
@alexcjohnson Sorry about that. I promoted this to |
Contributor
Author
|
@alexcjohnson I think this is ready for another round |
alexcjohnson
approved these changes
Sep 13, 2019
Collaborator
alexcjohnson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💃
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188
Requires a
dash-docsusage update: https://github.com/plotly/dash-docs/pull/642Up to now it was necessary to do:
in order to allow multiline & ellipsis.
With this change, it is possible to do it with only:
It's also now possible to set
white-space,overflowandtext-overflowinstyle_**and have it applied (inherited) by the cell's content without extra css.Alongside being simpler, it also fixes old/weird alignment issues we've been seeing in the documentation for a long time now:
Before

After

At some point, it might be interesting to know which css properties can safely be inherited by default by
div.dash-cell-valueand update https://github.com/plotly/dash-table/blob/188-multiline/src/dash-table/components/Table/Table.less#L367 with all those values.See follow up: #574