add tests for edit/delete/rename with hidden cols, and canceled name edit

Author: alexcjohnson

tests/cypress/tests/standalone/column_test.ts

@@ -27,6 +27,17 @@ describe(`column, mode=${AppMode.Actionable}, flavor=${AppFlavor.Merged}, ${AppF
         DashTable.getHeader(1, 1).within(() => cy.get('span.column-header-name').should('have.html', 'Paris'));
     });
 
+    it('keeps hidden pieces when deleting a merged column', () => {
+        cy.get('.column-4 .column-header--hide').click(); // Boston
+        cy.get('.column-2 .column-header--hide').click(); // Montréal
+        DashTable.deleteColumnById(0, 'ccc'); // City
+        cy.get('.show-hide').click();
+        cy.get('.show-hide-menu-item input').eq(1).click(); // Montréal
+        cy.get('.show-hide-menu-item input').eq(2).click(); // Boston
+        cy.get('.column-1 .column-header-name').eq(2).should('have.html', 'Montréal');
+        cy.get('.column-2 .column-header-name').eq(1).should('have.html', 'Boston');
+    });
+
     it('can clear column', () => {
         DashTable.getFilter(0).click();
         DOM.focused.type(`is num`);
@@ -62,6 +73,29 @@ describe(`column, mode=${AppMode.Actionable}, flavor=${AppFlavor.Merged}, ${AppF
         DashTable.getFilter(4).within(() => cy.get('input').should('have.value', ''));
     });
 
+    it('keeps hidden pieces when clearing a merged column', () => {
+        // initial state of city columns
+        DashTable.getCell(0, 1).within(() => cy.get('.dash-cell-value').should('have.html', '1'));
+        DashTable.getCell(0, 2).within(() => cy.get('.dash-cell-value').should('have.html', '100'));
+        DashTable.getCell(0, 3).within(() => cy.get('.dash-cell-value').should('have.html', '1'));
+        DashTable.getCell(0, 4).within(() => cy.get('.dash-cell-value').should('have.html', '2'));
+        DashTable.getCell(0, 5).within(() => cy.get('.dash-cell-value').should('have.html', '10'));
+
+        cy.get('.column-4 .column-header--hide').click(); // Boston
+        cy.get('.column-2 .column-header--hide').click(); // Montréal
+        DashTable.clearColumnById(0, 'ccc'); // City
+        cy.get('.show-hide').click();
+        cy.get('.show-hide-menu-item input').eq(2).click(); // Montréal
+        cy.get('.show-hide-menu-item input').eq(4).click(); // Boston
+
+        // after clear and re-show -> only Montréal and Boston have data
+        DashTable.getCell(0, 1).within(() => cy.get('.dash-cell-value').should('have.html', ''));
+        DashTable.getCell(0, 2).within(() => cy.get('.dash-cell-value').should('have.html', '100'));
+        DashTable.getCell(0, 3).within(() => cy.get('.dash-cell-value').should('have.html', ''));
+        DashTable.getCell(0, 4).within(() => cy.get('.dash-cell-value').should('have.html', '2'));
+        DashTable.getCell(0, 5).within(() => cy.get('.dash-cell-value').should('have.html', ''));
+    });
+
     it('can hide column', () => {
         DashTable.getHeader(0, 0).within(() => cy.get('span.column-header-name').should('have.html', 'rows'));
         DashTable.hideColumnById(0, 'rows');
@@ -313,4 +347,4 @@ describe(`column, mode=${AppMode.Actionable}`, () => {
         DashTable.getHeader(1, 2).within(() => cy.get('span.column-header-name').should('have.html', 'France'));
         DashTable.getHeader(2, 2).within(() => cy.get('span.column-header-name').should('have.html', 'Paris'));
     });
-});
+});

tests/cypress/tests/standalone/edit_headers.ts

@@ -51,6 +51,49 @@ describe(`edit, mode=${AppMode.Typed}`, () => {
         });
     });
 
+    describe(`edit headers while some columns are hidden`, () => {
+        beforeEach(() => {
+            cy.visit(`http://localhost:8080?mode=${AppMode.Actionable}&flavor=${AppFlavor.Merged}`);
+            DashTable.toggleScroll(false);
+        })
+        it('preserves hidden columns unchanged when editing visible names', () => {
+            cy.window().then((win: any) => {
+                cy.stub(win, 'prompt').returns('Chill');
+            });
+            // hide 3 columns - one at the start of a merged set, one in the middle, one not in the set
+            cy.get('.column-8 .column-header--hide').click({force: true});
+            cy.get('.column-6 .column-header--hide').click({force: true});
+            cy.get('.column-1 .column-header--hide').click({force: true});
+            // edit the merged name
+            cy.get('.dash-header.column-5 .column-header--edit').eq(1).click({force: true});
+            // re-show the hidden columns
+            cy.get('.show-hide').click();
+            cy.get('.show-hide-menu-item input').eq(1).click();
+            cy.get('.show-hide-menu-item input').eq(6).click();
+            cy.get('.show-hide-menu-item input').eq(8).click();
+            // all columns still exist
+            cy.get('.dash-header.column-9 .column-header-name').should('have.html', 'Temperature-RO');
+            // the columns that were hidden when the merged name was changed
+            // still changed name - so they're still all merged
+            cy.get('.dash-header.column-6[colspan="4"] .column-header-name').eq(1).should('have.html', 'Chill');
+        });
+    });
+
+    describe('edit headers, canceled edit', () => {
+        beforeEach(() => {
+            cy.visit(`http://localhost:8080?mode=${AppMode.SingleHeaders}`);
+            DashTable.toggleScroll(false);
+        });
+        it('preserves column name if edit is canceled', () => {
+            cy.window().then((win: any) => {
+                // user presses cancel -> prompt returns null
+                cy.stub(win, 'prompt').returns(null);
+            });
+            cy.get('.dash-header.column-0 .column-header--edit').eq(0).click();
+            cy.get('.dash-header.column-0 > div > span:last-child').should('have.html', 'rows');
+        });
+    });
+
     describe(`edit headers, mode=${AppMode.SingleHeaders}`, () => {
         beforeEach(() => {
             cy.visit(`http://localhost:8080?mode=${AppMode.SingleHeaders}`);