Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Commit bf0b3b3

Browse files
committed
fix canceled column name edit
1 parent 2d30db0 commit bf0b3b3

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/dash-table/derived/header/content.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,10 @@ function doSort(columnId: ColumnId, sortBy: SortBy, mode: SortMode, setProps: Se
101101

102102
function editColumnName(column: IColumn, columns: Columns, columnRowIndex: any, setProps: SetProps, mergeDuplicateHeaders: boolean) {
103103
return () => {
104-
setProps(actions.editColumnName(column, columns, columnRowIndex, mergeDuplicateHeaders));
104+
const update = actions.editColumnName(column, columns, columnRowIndex, mergeDuplicateHeaders);
105+
if (update) {
106+
setProps(update);
107+
}
105108
};
106109
}
107110

src/dash-table/utils/actions.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,5 +121,8 @@ export function changeColumnHeader(column, columns, headerRowIndex, mergeDuplica
121121

122122
export function editColumnName(column, columns, headerRowIndex, mergeDuplicateHeaders) {
123123
const newColumnName = window.prompt('Enter a new column name');
124+
if (newColumnName === null) {
125+
return null;
126+
}
124127
return changeColumnHeader(column, columns, headerRowIndex, mergeDuplicateHeaders, newColumnName);
125128
}

0 commit comments

Comments
 (0)