Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

merge dev into master 1.1.2 #177

Merged
merged 22 commits into from
Jan 19, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7b153ea
Use authenticated Docker pulls (#167)
rpkyle Oct 6, 2020
f25b324
Update CODEOWNERS
Marc-Andre-Rivet Dec 9, 2020
20ffc24
Bump dot-prop from 4.2.0 to 4.2.1
dependabot[bot] Dec 9, 2020
57c309f
improve dash import test
alexcjohnson Dec 10, 2020
6f3a51c
changelog for import bug fix
alexcjohnson Dec 10, 2020
66ba2ac
Merge pull request #169 from plotly/import-test
alexcjohnson Dec 10, 2020
1d64c8a
update extract-attributes script for latest MDN page structure
alexcjohnson Dec 15, 2020
4aebb6a
description for setProps - to reduce warnings
alexcjohnson Dec 15, 2020
566dc70
Merge pull request #170 from plotly/mdn-update-yari
alexcjohnson Dec 15, 2020
49273a7
use dash loosen-testing-reqs branch and fix linting
alexcjohnson Dec 17, 2020
2efbc76
Fix spelling
jbampton Dec 17, 2020
9d5e8d2
back to dev branch of dash
alexcjohnson Dec 17, 2020
6b57110
Merge pull request #172 from jbampton/fix-spelling
alexcjohnson Dec 17, 2020
b5f80df
Merge pull request #171 from plotly/dash-1506
alexcjohnson Dec 17, 2020
2b9df15
Merge pull request #168 from plotly/dependabot/npm_and_yarn/dot-prop-…
alexcjohnson Dec 17, 2020
72c97cc
update component gen for MDN update Jan 2021
alexcjohnson Jan 6, 2021
aea3d2b
error message if element count changes from expectation
alexcjohnson Jan 6, 2021
08c4ce1
add reference to MDN PR with the math & svg addition
alexcjohnson Jan 7, 2021
b02c657
Merge pull request #174 from plotly/moz-update-jan-2021
alexcjohnson Jan 7, 2021
9fe5e1f
bump to v1.1.2 (#176)
harryturr Jan 19, 2021
b3354a9
Merge branch 'dev' into 1.1.2-master
harryturr Jan 19, 2021
b8a0d9f
artifacts
harryturr Jan 19, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/extract-attributes.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ const attributeMap = supportedAttributes.reduce((map, reactAttribute) => {
* descriptions and supported elements.
*/
function extractAttributes($) {
const $table = $('#Attribute_list').next('table');
const $table = $('#Attribute_list').parent().find('table');
if($table.length !== 1) {
throw new Error('page structure changed at ' + htmlURL);
}
const attributes = {};

$table.find('tbody tr').each((i, row) => {
Expand Down
3 changes: 3 additions & 0 deletions scripts/generate-components.js
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ function generatePropTypes(element, attributes) {
component_name: PropTypes.string,
}),

/**
* Dash-assigned callback that gets fired when the element is clicked.
*/
'setProps': PropTypes.func`
}

Expand Down