Skip to content

Remove selected nodes after they are deleted #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2019
Merged

Remove selected nodes after they are deleted #49

merged 2 commits into from
Apr 5, 2019

Conversation

xhluca
Copy link

@xhluca xhluca commented Apr 4, 2019 •
edited
Loading

About

Description of changes

Pre-Merge checklist

  • The project was correctly built with npm run build:all.
  • If there was any conflict, it was solved correctly
  • All changes were documented in CHANGELOG.md.
  • All tests on CircleCI have passed.
  • All Percy visual changes have been approved.
  • Two people have 💃'd the pull request. You can be one of these people if you are a Dash Cytoscape core contributor.

Reference Issues

Closes #45

Other comments

Xing Han Lu added 2 commits April 3, 2019 18:14
@shammamah-zz
Copy link
Contributor

shammamah-zz commented Apr 4, 2019 •
edited
Loading

@xhlulu For reference, if you put "Closes #45" in the body of the PR, it will automatically link the two and close the issue once this PR is merged :)

Edit: looks like it applies to commit messages too!

@xhluca
Copy link
Author

xhluca commented Apr 4, 2019

Done!

@xhluca xhluca changed the title Remove selected nodes after they are deleted (Fix #45) Remove selected nodes after they are deleted Apr 4, 2019
shammamah-zz
shammamah-zz approved these changes Apr 4, 2019
View reviewed changes
@xhluca xhluca merged commit 8b08621 into master Apr 5, 2019
@xhluca xhluca deleted the element-removal branch April 5, 2019 15:40
@xhluca xhluca mentioned this pull request Apr 5, 2019
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shammamah-zz shammamah-zz shammamah-zz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selected Nodes stays in selectedNodeData permanently after being deleted
2 participants
@xhluca @shammamah-zz