Conversation
HammadTheOne
requested review from
Marc-Andre-Rivet,
alexcjohnson and
rpkyle
as code owners
There was a problem hiding this comment.
Hmm, not sure what happened, but doesn't look like the vignettes are building/included for me when I install from this branch. This is partial output from browseVignettes():
I can see dashHtmlComponents, which has been rebuilt, but dashCoreComponents is missing.
We should probably ensure that the vignettes are restored to the dash package before releasing to CRAN also.
| export(dccTimer) | ||
| export(dccGeolocation) No newline at end of file |
There was a problem hiding this comment.
I guess these are in development (e.g. #962), but removed from the NAMESPACE because they haven't been merged to dev yet?
There was a problem hiding this comment.
I believe so. I'm not sure why those are in the NAMESPACE to begin with since they're not included in the dev branch yet, but I think it's safe to remove them for now until they're added back with the merge of that PR.
| library(dashHtmlComponents) | ||
| library(dashCoreComponents) |
Co-authored-by: Ryan Patrick Kyle <rpkyle@users.noreply.github.com>
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 - pending confirmation from @HammadTheOne that the vignettes do indeed show up when he builds on this branch 😅
|
Vignettes are successfully generated 🚀
|
3 participants
This PR updates the R package vignettes and
dash-info.yamlfor consistency with the Dash R monopackage update plotly/dashR#243.