Skip to content

Andrew/verbose error #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Aug 8, 2025
Merged

Andrew/verbose error #374

merged 23 commits into from
Aug 8, 2025

Conversation

ayjayt
Copy link
Collaborator

@ayjayt ayjayt commented Aug 1, 2025 •
edited
Loading

  1. Checks to see if there are 0 tabs (usually means you haven't opened Kaleido)
  2. Bumps minimum choreographer version (helps with hanging)
  3. During task clean, checks if cancelled() before exception() this is proper order.

@ayjayt ayjayt requested a review from emilykl August 1, 2025 22:58
@ayjayt ayjayt marked this pull request as ready for review August 8, 2025 13:28
@ayjayt
Copy link
Collaborator Author

ayjayt commented Aug 8, 2025

I'm still merging on local, so have to sqash this, not rebase :-(

emilykl
emilykl reviewed Aug 8, 2025
View reviewed changes
ayjayt and others added 2 commits August 8, 2025 15:27
@ayjayt @emilykl
Update src/py/kaleido/kaleido.py
1e27b99 
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
@ayjayt
Eliminate dev comments.
891db9c
@ayjayt ayjayt merged commit 5cad40c into master Aug 8, 2025
4 checks passed
@ayjayt ayjayt deleted the andrew/verbose-error branch August 8, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilykl emilykl emilykl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayjayt @emilykl