-
Notifications
You must be signed in to change notification settings - Fork 78
Added %sqlplot
tests
#628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added %sqlplot
tests
#628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
@mehtamohit013
Can we add more complex cases (a large number of bins (100/250/500), 2 plots, custom style, vertical/horizontal bar)? For this, we'll probably need a more complete dataset.
We can use these as references:
What do you mean by 2 plots? 2 histogram in one? TLDR: Added all the plots present in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mehtamohit013
lgtm. Just one comment about the fixture and I think it's ready for merge.
What do you mean by 2 plots? 2 histogram in one?
Yes. I see you already did it.
Describe your changes
Added
%sqlplot
tests for boxplot and histogramIssue number
Closes #526
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--628.org.readthedocs.build/en/628/