removes start event from telemetry #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idomic
reviewed
Oct 25, 2023
| @@ -75,7 +75,7 @@ For more details, see the [API Reference](api/telemetry). | |||
|
|
|||
| +++ | |||
|
|
|||
| To unit test decorated functions, call the function and check `__wrapped__._telemetry_started` attribute. If it exists, it means the function has been decorated with `@log_call()`, you can use it to verify what's logged: | |||
| To unit test decorated functions, call the function and check `__wrapped__._telemetry_success` attribute. If it exists, it means the function has been decorated with `@log_call()`, you can use it to verify what's logged: | |||
There was a problem hiding this comment.
Maybe it'd make more sense to keep the started? I saw there are more started then success (probably since it failed in the middle).
|
merging this since I discussed with @idomic that removing the |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
when recording telemetry events, we used to store a start and success/fail event. to reduce the number of events, we only trigger success/fail now.
the actual change is just a few lines of code, the rest are tests that had to be updated
once this is approved, I can make a new release
Issue number
Closes #X
Checklist before requesting a review
pkgmt format📚 Documentation preview 📚: https://ploomber-core--77.org.readthedocs.build/en/77/