Skip to content

Seven listing block#8252

Open
nileshgulia1 wants to merge 40 commits into
sevenfrom
seven-listing-block
Open

Seven listing block#8252
nileshgulia1 wants to merge 40 commits into
sevenfrom
seven-listing-block

Conversation

@nileshgulia1

Copy link
Copy Markdown
Member

This PR is based on the Querystring Widget changes introduced in #8017. That PR should be merged first, after which the target branch for this PR can be updated accordingly.


props.onFormDataChange?.(nextData);
},
onPatchFormData: (partial: Record<string, unknown>) => {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove this!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion with @robgietema , the querystring-search call should be made from the block not the widget. We might consider moving the withQuerystringResults to seven or develop something like it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the hook in b080787

@davisagli davisagli added this to the Seven milestone May 19, 2026
@nileshgulia1
nileshgulia1 marked this pull request as ready for review May 21, 2026 16:51
Base automatically changed from seven-querystring to seven June 4, 2026 08:08
@sneridagh

Copy link
Copy Markdown
Member

@nileshgulia1 I merged #8017.

@sneridagh

Copy link
Copy Markdown
Member

We will need a good battery of tests here.

@nileshgulia1

Copy link
Copy Markdown
Member Author

Thanks @sneridagh I will bring this PR up to date. With some tests for feature.

@sneridagh

Copy link
Copy Markdown
Member

Important

Hello! Thanks for contributing to Plone Aurora! FYI, since June 5th, Plone Aurora lives in its own repository, thus, the seven branch does not accept any merges. If you want to merge your PR, please follow instructions: #8318
Sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants