Skip to content

Conversation

@Shauryan0207
Copy link

Description

contentIcons and controlPanelsIcons in config.Settings are typed as Record<string, React.ComponentType> but should be Record<string, string> because they contain SVG file paths, not React components.

Changes

  • Fixed contentIcons type from React.ComponentType to string
  • Fixed controlPanelsIcons type from React.ComponentType to string
  • Added changelog entry

Checklist

  • I signed the Plone Contributor Agreement
  • Verified no other PRs for this change
  • Followed Volto contribution guidelines
  • No tests needed (type-only fix)
  • Added changelog entry: packages/types/news/7339.bugfix

Related

Closes #7339

…lone#7339)

Changed contentIcons and controlPanelsIcons types from Record<string, React.ComponentType> to Record<string, string> as they contain SVG file paths, not React components.
@mister-roboto
Copy link

@Shauryan0207 you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

If you have already signed the agreement, please allow a week for your agreement to be processed.
Once it is processed, you will receive an email invitation to join the plone GitHub organization as a Contributor.

If after a week you have not received an invitation, then please contact agreements@plone.org.

@Shauryan0207
Copy link
Author

I have signed it

@stevepiercy
Copy link
Collaborator

@Shauryan0207 please read and follow the third and fourth sentences. After that's completed, then add a comment stating that you've completed the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@plone/types: Wrong typing for config.Settings.contentIcons

3 participants