-
-
Notifications
You must be signed in to change notification settings - Fork 840
Fix Toolbar Types crash when language code is missing in langmap (#7637) #7676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix Toolbar Types crash when language code is missing in langmap (#7637) #7676
Conversation
|
@pratyush07-hub If I add Cannot read properties of undefined (reading 'nativeName')I can't even add content afterwards. Perhaps issue #7637 is incomplete? |
I have checked it, and this is an additional issue that is not covered by my PR. |
Hi @wesleybl , Screencast.from.2025-12-05.14-09-58.webm |
|
Hi @wesleybl @stevepiercy , I’ve been looking into the crash that happens when Plone has a language that Volto doesn’t recognize in its LanguageMap. What’s going wrong: What I am trying to do:
However, these fixes alone are not enough. I need your guidance here:
I am thinking that option 2 might be the better choice, but I’d like your guidance. |
If the backend supports a specific language and the user has selected that language, I think it's best not to have limitations and only display the language code. I don't think we need to update LanguageMap.js if Volto doesn't support that language. |
This fixes a bug where the Toolbar Types component crashes if a language in Plone is not in Volto’s langmap.
This PR fixes the issue by :
Files changed:
Changelog:
Closes #7637