Skip to content

Conversation

@iFlameing
Copy link
Member

@iFlameing iFlameing commented Nov 27, 2025

Caution

The Volto Team has suspended its review of new pull requests from first-time contributors until the release of Plone 7, which is preliminarily scheduled for the second quarter of 2026.
Read details.



If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #7464


If your pull request includes changes to the documentation—either in narrative documentation, Storybook, or configuration—then a pull request preview will be generated and a link will populate in the description of your pull request below.
By clicking that link, you can use the visual diff menu in the upper right corner to navigate to pages that have changes, then display the diff by checking the Show diff checkbox.

@iFlameing iFlameing marked this pull request as draft November 27, 2025 15:07
@iFlameing iFlameing requested a review from sneridagh December 2, 2025 08:59
@iFlameing iFlameing marked this pull request as ready for review December 2, 2025 09:01
Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, please take a look at the styling and polish it a bit:

image

Remove the margin bottom: 1em, and force the height of that widget (only there, in this context, beware that it does not leak!) to 60px, which is the default of all the inputs.

@iFlameing
Copy link
Member Author

@sneridagh did some changes as you said can you please review it once again.

@iFlameing iFlameing requested a review from sneridagh December 2, 2025 14:21
@sneridagh
Copy link
Member

@iFlameing I tested it again, and the object browser allows you to add items that are not folderish, which has no sense at all. Could you please check if we can add the constraint to the OBwidget?

Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging for now for 19.

@plone/volto-team I will merge it, since I think it's relevant to have it already merged. We can polish later in the alpha. Also, let's discuss the inclusion of this in 18 in the next meeting.

@sneridagh sneridagh merged commit 5c27311 into main Dec 8, 2025
83 checks passed
@sneridagh sneridagh deleted the location-widget branch December 8, 2025 10:12
@wesleybl
Copy link
Member

wesleybl commented Dec 9, 2025

It would be nice to have this in Volto 18. I missed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Listing Block: Allow editors to choose a content object as location criterion

4 participants