Fix: Handle undefined language field in multilingual content (#7309) #7635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) This commit fixes a critical bug where content with plone.translatable behavior but without plone.dublincore behavior causes runtime errors when accessing content.language.token. Changes: - Add getLanguageToken helper function to safely extract language tokens - Fix AlternateHrefLangs component to use helper function - Fix ManageTranslations component to use helper function (7 occurrences) - Fix Edit component to use helper function (3 occurrences) - Add comprehensive unit tests for getLanguageToken (8 test cases) The helper function handles three cases: 1. language is undefined/null → returns null 2. language is a string → returns the string 3. language is an object with token → returns token property This ensures backwards compatibility while fixing the crash for content types that don't include plone.dublincore behavior. Fixes plone#7309
wesleybl
requested changes
Nov 26, 2025
| */ | ||
| export function getLanguageToken(language) { | ||
| if (!language) return null; | ||
| if (typeof language === 'string') return language; |
Member
There was a problem hiding this comment.
The language attribute in Plone is of type schema.Choice. Therefore, it will always be an object. I suggest a simpler fix, with:
content?.language.token
Member
|
Backport also to 18.x.x please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix language token crash in multilingual content
The Problem
I ran into this bug while working with custom content types. When you add translation support (
plone.translatablebehavior) to content but don't include the full Dublin Core behavior (which has the Language field), Volto crashes with:This happens because the code assumes
content.languageis always an object with a.tokenproperty, but it can actually be:undefined(no language set)"en".tokenlike{ token: "en", title: "English" }What I Changed
Added a helper function
getLanguageToken()that safely handles all three cases. Then updated these components to use it:content.language.tokenTesting
I added 8 unit tests covering all the edge cases:
The fix is backwards compatible - existing code with proper language objects keeps working, and now content without Dublin Core doesn't crash anymore.
Files Changed
src/helpers/Content/Content.js- AddedgetLanguageToken()helpersrc/helpers/Content/Content.test.js- Added test coveragesrc/components/theme/AlternateHrefLangs/AlternateHrefLangs.jsx- Use helpersrc/components/manage/Multilingual/ManageTranslations.jsx- Use helper (7 spots)src/components/manage/Edit/Edit.jsx- Use helper (3 spots)news/7309.bugfix- Changelog entryCloses #7309