Skip to content

Commit

Permalink
Dx fields validation (#1454)
Browse files Browse the repository at this point in the history
* implemented widgets and display all errors set on backend for the specific fields

* implemented show backend errors on corresponding fields, auto select the first tab that has any errors, clear errors if user starts editing the fields

* improved validation to clear error for the field that is being changed and re-validate on blur

* fixed date widget for type date (date only)

* fixed show errors from backend to corresponding fields

* Added Changelog

* Fix tests to handle boolean required fields and ModalForm

* Fix guillotina tests

* added locales and Changelog

* prettier

* added fix for comments

* i18n update

* prettier:fix

* i18n

* i18n

* i18n

* Fix typo

* Fix cross-origin in Event: missing formData

* Fix toast cleanup on request error

* removed dateOnly prop from Form

* removed prop type for value in SelectWidget

* yarn run prettier

* DatetimeWidget cleanup

* DatetimeWidget dateOnly condition includes received from prop

* Fix field validation with SchemaWidget

* Cleanup URL, Email, Text, Password widgets

* Update Email, Password, URL Widgets tests

* i18n

* Revert TextWidget as now we have dedicated Number Widget

* Handle NumberWidget validation

* Revert SelectWidget imports re-order

* SelectWidget fixes

* Cleanup password widget

* Revert re-order imports PasswordWidget

* Cleanup NumberWidget

* Cleanup NumberWidget

* yarn i18n

* yarn i18n

Co-authored-by: Alex Medesan <alex.medesan@gmail.com>
  • Loading branch information
avoinea and Alex Medesan authored Sep 15, 2020
1 parent 80a48e5 commit 0782a50
Show file tree
Hide file tree
Showing 63 changed files with 2,236 additions and 874 deletions.
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,21 @@

### Feature

- Added missing components for Email and Url widgets #1246 @rexalex

- Show backend validation errors on corresponding fields #1246 @rexalex

- Validation implemented for add user/group @rexalex
- Show Username when Firstname attr is missing in UsersControlPanelUser @iFlameing

### Bugfix

- Fixed front-end field validation #1246 @rexalex

- Fixed date only widget rendering #1246 @rexalex

- Fix errors with SelectWidget when removing the only element @rexalex

### Internal

## 7.14.2 (2020-09-10)
Expand Down Expand Up @@ -300,6 +311,9 @@

## 7.0.1 (2020-07-07)

### Breaking


### Bugfix

- Adding absolute url in ObjectBrowser for image type @iFlameing
Expand Down
2 changes: 1 addition & 1 deletion locales/de.json

Large diffs are not rendered by default.

Loading

0 comments on commit 0782a50

Please sign in to comment.