Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundles (step 9) #91

Merged
merged 5 commits into from
Jul 17, 2020
Merged

Update bundles (step 9) #91

merged 5 commits into from
Jul 17, 2020

Conversation

@mister-roboto
Copy link

@vincentfretin thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@vincentfretin
Copy link
Member Author

@jenkins-plone-org please run jobs

@vincentfretin
Copy link
Member Author

We may fix other mockup issues, so don't merge this yet.

@ale-rt
Copy link
Member

ale-rt commented Jul 6, 2020

Amazing work so far! Thanks a lot :)

@vincentfretin
Copy link
Member Author

@jenkins-plone-org please run jobs

@vincentfretin
Copy link
Member Author

@jenkins-plone-org please run jobs

@vincentfretin
Copy link
Member Author

@mauritsvanrees You can merge if you're about to release the other packages.

Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mauritsvanrees mauritsvanrees merged commit f55ec95 into master Jul 17, 2020
@mauritsvanrees mauritsvanrees deleted the bundles-step9 branch July 17, 2020 14:01
@mauritsvanrees
Copy link
Member

I have merged, and will do releases now.

@mauritsvanrees
Copy link
Member

I have released mockup 3.2.1 and plone.staticresources 1.3.1.

I have updated these versions on the coredev 5.2 branch, but have not pushed it yet. I am doing more releases, and do not want to overload Jenkins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants