-
-
Notifications
You must be signed in to change notification settings - Fork 95
Fix #1956: Add multipart email support to /@email-send endpoint #1957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix #1956: Add multipart email support to /@email-send endpoint #1957
Conversation
|
@Manik-Khajuria-5 you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement If you have already signed the agreement, please allow a week for your agreement to be processed. If after a week you have not received an invitation, then please contact agreements@plone.org. |
|
@Manik-Khajuria-5 thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
@Manik-Khajuria-5 you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement If you have already signed the agreement, please allow a week for your agreement to be processed. If after a week you have not received an invitation, then please contact agreements@plone.org. |
davisagli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message intro is enforced to make sure the site is providing adequate context for the email. If we make this configurable it should be a setting that a site admin can configure in the mail control panel, not a parameter that can be overridden for a specific email.
61c80ab to
36883e3
Compare
|
@Manik-Khajuria-5 please edit your PR description as described in https://6.docs.plone.org/contributing/first-time.html#create-a-pull-request-from-your-fork item 2. |
news/1956.bugfix.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this news item, as it's already covered by the other news item, and this one does not conform with https://6.docs.plone.org/contributing/index.html#create-a-news-item-file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing! I’ve applied your suggested one-line news entry with my credit. The duplicate news file was also removed. Please let me know if anything else is needed.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
|
One more time:
|
stevepiercy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
News LGTM. This still needs a technical review.
Summary
Fixes #1956
This PR fixes the behavior of the
/@email-sendendpoint when handling multipart or preformatted email messages.Problem
Plone always prepended
message_introtext to outgoing emails, even for multipart messages.This broke the structure of multipart emails (HTML + text, attachments, etc.).
What this PR changes
message_from_string.Why this is needed
Multipart messages must not have additional text injected into their payload, or the message structure becomes invalid.
News item
A news file was added:
1952.bugfix