Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RESOLVEUID_RE regexp to catch also paths generated by Link content-types #1700

Merged
merged 5 commits into from
Sep 3, 2023

Conversation

cekk
Copy link
Member

@cekk cekk commented Aug 28, 2023

No description provided.

@cekk cekk requested review from mamico and tisto August 28, 2023 16:02
@mister-roboto
Copy link

@cekk thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit e08e0ce
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64ecc508fc9cb40008af37b7

@cekk
Copy link
Member Author

cekk commented Aug 29, 2023

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit 36e67bd into main Sep 3, 2023
@davisagli davisagli deleted the improve_resolveuid_re branch September 3, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants