Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish docs for v9 release. #1698

Merged
merged 2 commits into from
Aug 27, 2023
Merged

Polish docs for v9 release. #1698

merged 2 commits into from
Aug 27, 2023

Conversation

stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Aug 26, 2023

This PR adds some MyST syntax for inline literals.

@stevepiercy stevepiercy self-assigned this Aug 26, 2023
@netlify
Copy link

netlify bot commented Aug 26, 2023

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit fbbe6dd
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64e9ca2f2513780008ff3dd4

@stevepiercy stevepiercy requested a review from tisto August 26, 2023 09:46
@mister-roboto
Copy link

@stevepiercy thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@stevepiercy stevepiercy requested a review from davisagli August 26, 2023 09:46
@stevepiercy
Copy link
Contributor Author

@jenkins-plone-org please run jobs

Copy link
Member

@tisto tisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevepiercy! That's definitely an improvement! :)

@tisto tisto merged commit b58560e into main Aug 27, 2023
@tisto tisto deleted the docs-polish-for-9 branch August 27, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants