Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes for #1599 #1692

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Documentation fixes for #1599 #1692

merged 3 commits into from
Aug 24, 2023

Conversation

stevepiercy
Copy link
Contributor

Formatting, MyST, grammar fixes.

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 8d8fa24
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64e754221d61660008be7a3c

@mister-roboto
Copy link

@stevepiercy thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@stevepiercy stevepiercy requested review from erral and davisagli August 24, 2023 11:59
@stevepiercy stevepiercy self-assigned this Aug 24, 2023
@stevepiercy
Copy link
Contributor Author

@jenkins-plone-org please run jobs

@stevepiercy
Copy link
Contributor Author

#1693 needs to be merged to pass the failed workflow.

@tisto tisto merged commit bd4ee27 into master Aug 24, 2023
@tisto tisto deleted the docs-fixes-1599 branch August 24, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants