fix: plone.restapi must work with dependency on only Products.CMFPlone #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
✅ Deploy Preview for plone-restapi canceled.
|
This comment was marked as outdated.
This comment was marked as outdated.
jensens
changed the title
…lone currently it depends on plone.app.itertae. The assumption, that it is always there is wrong, it is an internal addon, only installed when dependening on 'Plone'.
|
@jenkins-plone-org please run jobs |
|
The failing test seems unrelated to my changes. |
|
@jenkins-plone-org please run jobs |
mauritsvanrees
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently restapi depends on
plone.app.iterate.The assumption, that it is always there, is wrong: it is an (internal) addon, only installed when dependening on 'Plone'.