Skip to content

++api++ traverser should be kept on 30x redirections - #130

Merged
tisto merged 4 commits into
masterfrom
fix_redirector_with_new_traverser
Feb 12, 2022
Merged

++api++ traverser should be kept on 30x redirections#130
tisto merged 4 commits into
masterfrom
fix_redirector_with_new_traverser

Conversation

@mamico

@mamico mamico commented Feb 11, 2022

Copy link
Copy Markdown
Member

Fix #127

@mister-roboto

This comment was marked as resolved.

@mamico
mamico requested review from jensens and tisto and removed request for jensens and tisto February 11, 2022 14:29
@mamico
mamico marked this pull request as draft February 11, 2022 14:32
@tisto
tisto requested a review from jensens February 11, 2022 15:30
@mamico

mamico commented Feb 11, 2022

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@mamico
mamico marked this pull request as ready for review February 11, 2022 15:36

@jensens jensens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I am not a fan of filter, but in this case it makes me smile, using __ne__.
(all checks tests need to be green too)

@mamico

mamico commented Feb 12, 2022

Copy link
Copy Markdown
Member Author

(all checks tests need to be green too)

Actually, the only test red is the black linter, but seems to me completely unrelated to this PR

@tisto
tisto merged commit 5a29afd into master Feb 12, 2022
@tisto
tisto deleted the fix_redirector_with_new_traverser branch February 12, 2022 15:35
@mamico mamico mentioned this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

++api++ traverser should be kept on 30x redirections

4 participants