Skip to content

Fix #23 + README overhaul #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Fix #23 + README overhaul #38

merged 3 commits into from
Jan 18, 2022

Conversation

jensens
Copy link
Member

@jensens jensens commented Jan 11, 2022

#23 adds make to runDeps in order to simplify Makefile usage in images inheriting from here.

Also did an overhaul of README (Markdown Style, minor wording, extensions.

@jensens jensens requested review from avoinea and ericof January 11, 2022 14:59
Copy link
Member

@ericof ericof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stevepiercy
Copy link
Contributor

Since this has docs in the readme, I reckon I should give y'all a heads up. I have a draft PR that creates a new space in the Plone 6 Documentation for backend. It is developer reference documentation, not end user documentation.

plone/documentation#1141

The branch 6-dev is the primary development branch for Plone 6 Documentation.

@jensens
Copy link
Member Author

jensens commented Jan 18, 2022

since this README is displayed on docker hub it should contain at least basic information. For in-depth information it is fine to point to docs.plone.org.

@jensens jensens merged commit 065e25d into main Jan 18, 2022
@jensens jensens deleted the fix-23 branch January 18, 2022 12:44
@jensens
Copy link
Member Author

jensens commented Jan 18, 2022

I'll create an issue about documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants