-
-
Notifications
You must be signed in to change notification settings - Fork 175
Searching #1176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ksuess thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
✔️ Deploy Preview for 6-dev-docs-plone-org ready! 🔨 Explore the source changes: 1df3efd 🔍 Inspect the deploy log: https://app.netlify.com/sites/6-dev-docs-plone-org/deploys/6204e06669cb67000706aff5 😎 Browse the preview: https://deploy-preview-1176--6-dev-docs-plone-org.netlify.app/volto/plone6index.html |
This netlify preview of a PR is awesome! https://deploy-preview-1176--6-dev-docs-plone-org.netlify.app/search.html?q=blocks |
Holy frijoles! This is amazing! And the Netlify preview feature is a huge time saver. |
Focussing on search field has hiccups on netlify preview. |
Preview of this version: https://deploy-preview-1176--6-dev-docs-plone-org.netlify.app/search.html?q=blocks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find where the amount of context is returned in this PR. I think we need to double or triple the length of <p class="context">...Contents Sidebar Schema driven automated block settings forms Object Browser openObjectBrowser handler API...</p>
because it does not provide enough context.
Context of search results: There are some strange exceptions I don't want to investigate now, but postpone to a date when we have more content to check on.
In most cases it works quite fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jenkins-plone-org please run jobs |
Fixes #1156