Skip to content

Searching #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 10, 2022
Merged

Searching #1176

merged 11 commits into from
Feb 10, 2022

Conversation

ksuess
Copy link
Member

@ksuess ksuess commented Feb 6, 2022

Fixes #1156

  • Add breadcrumbs to search results
  • Search form nicer with bootstrap

@mister-roboto
Copy link

@ksuess thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@netlify
Copy link

netlify bot commented Feb 6, 2022

✔️ Deploy Preview for 6-dev-docs-plone-org ready!

🔨 Explore the source changes: 1df3efd

🔍 Inspect the deploy log: https://app.netlify.com/sites/6-dev-docs-plone-org/deploys/6204e06669cb67000706aff5

😎 Browse the preview: https://deploy-preview-1176--6-dev-docs-plone-org.netlify.app/volto/plone6index.html

@ksuess ksuess requested a review from stevepiercy February 6, 2022 12:18
@ksuess
Copy link
Member Author

ksuess commented Feb 6, 2022

This netlify preview of a PR is awesome! https://deploy-preview-1176--6-dev-docs-plone-org.netlify.app/search.html?q=blocks

@stevepiercy
Copy link
Contributor

Holy frijoles! This is amazing! And the Netlify preview feature is a huge time saver.

@ksuess ksuess requested a review from stevepiercy February 9, 2022 20:29
@ksuess
Copy link
Member Author

ksuess commented Feb 9, 2022

Focussing on search field has hiccups on netlify preview.

@stevepiercy
Copy link
Contributor

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find where the amount of context is returned in this PR. I think we need to double or triple the length of <p class="context">...Contents Sidebar Schema driven automated block settings forms Object Browser openObjectBrowser handler API...</p> because it does not provide enough context.

@ksuess
Copy link
Member Author

ksuess commented Feb 10, 2022

Context of search results: There are some strange exceptions I don't want to investigate now, but postpone to a date when we have more content to check on.
These exceptions are:

In most cases it works quite fine now.
Some examples how it should be

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge!

I created an issue to track the bug you discovered.

#1177

@stevepiercy
Copy link
Contributor

@jenkins-plone-org please run jobs

@ksuess ksuess merged commit 2ab5703 into 6-dev Feb 10, 2022
@ksuess ksuess deleted the searching branch February 10, 2022 10:04
@ksuess ksuess self-assigned this Aug 2, 2022
@ksuess ksuess added this to the Plone 6.0 milestone Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Search results should show breadcrumbs
3 participants