Fix view subtemplate dedup and generated test fixtures - #6
Merged
Conversation
A second view sharing a URL name but registered for a different interface was skipped as a duplicate. has_element/extend_configure_zcml now accept extra identifying attributes; the view hook uses name + for.
invoke/watchdog move to a PEP 735 [dependency-groups] dev (auto-installed by uv run), the test task requests the test extra, and CI installs .[test]. Without this 'plonecli test' could not spawn invoke or pytest.
The conftest defines the 'integration' fixture, but subtemplate tests referenced 'integration_testing', so every test errored at setup. Content-type tests also queried the FTI by the DexterityFTI class instead of the IDexterityFTI interface, always getting None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
viewsubtemplate's duplicate detection: abrowser:pageis now identified by both itsnameandforinterface, so distinct views for different contexts are no longer wrongly treated as duplicates (xml_updater.py,view/copier_hooks.py).uv(zope-setuppyproject/tasks/CI).integrationfixture andIDexterityFTIconsistently.Test plan
tests/test_view.pyandtests/test_zope_setup.py(run in CI).