Repository navigation
Use @plone/icons for the SVG types in the Aurora add-on - #475
Merged
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
sneridagh
marked this pull request as ready for review
October 3, 2026 17:23
Member
Author
|
@ericof also this one :) I will need a release too! |
Member
Release of what? |
ericof
approved these changes
Oct 3, 2026
Member
Author
|
@ericof are you not releasing the cookieplone-templates repo? |
Member
|
Not necessarily |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #474, for plone/aurora#212. That PR moves the
*.svg?reactmodule declaration from@plone/components/iconsto@plone/icons/svgand removes the old subpath. Generated add-ons then failmake lint:Changes in the
aurora_addontemplate:types.d.ts:import '@plone/components/icons'→import '@plone/icons/svg'package.json: add"@plone/icons": "workspace:*"package.json:build:depsalso builds@plone/iconsand@plone/quanta(same as the Makefile change in Build @plone/icons and @plone/quanta in the Aurora add-on build-deps #474)Draft: merge only after an Aurora release that includes plone/aurora#212. The template defaults
aurora_versionto the latest npm release, and@plone/iconsdoesn't exist in 1.0.0-alpha.15 or earlier, so merging now would break newly generated add-ons.The upgrade steps for existing add-ons are documented in plone/aurora#212 (
docs/upgrade-guide/plone-aurora.md).🤖 Generated with Claude Code