Skip to content

Conversation

@kakshay21
Copy link
Member

see #45

eggs = i18ndude


[translate]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please pay a bit more attention on how you name things!
What does this part do?
Also this is the name which will be placed into the bin folder.
So we want something there, which makes sense.
And please generate a package and test if it works ;)



[translate]
recipe = plone.recipe.command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a problem with this recipe. It only runs when we run buildout. Thats not what we want here. We need to create a script in bin folder. I'll copy my comments from the chat here too, for documentation:

We could use Python entry points for the locales script. We can't use a shell script, because we want also support windows. If we have a simple entry point, we could let buildout generate a script in the bin folder, as we do for the zopepy script for example.

@kakshay21 kakshay21 requested a review from encolpe June 23, 2018 13:20
@kakshay21 kakshay21 closed this Jun 23, 2018
@kakshay21 kakshay21 deleted the akshay-locale-script branch June 23, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants