V2 #122
Merged
V2 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jkralik
commented
May 6, 2020
•
jkralik
commented
- protocols are separated to packages
- observe work's natively (Handle blockwise observation responses #12, blockwise observe #99)
- support's separate message
- don't propagate reset message to client(mcast server - received RST processed as request? #110)
- body as ReadSeeker for easy transfer files
- ability to set source port (connect to coap server with specific source port #90)
- (un)marshal udp/tcp coap message without allocation
- added support for middleware to mux Middleware support #73
+ use require to check return values in tests
TODO: blockwise, keepalive
increase coverage tests
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 60.14% 60.14%
=======================================
Files 50 50
Lines 3756 3756
=======================================
Hits 2259 2259
Misses 1202 1202
Partials 295 295 Continue to review full report at Codecov.
|
Closed
cizmazia
reviewed
May 26, 2020
cizmazia
reviewed
May 26, 2020
| }() | ||
|
|
||
| var wg sync.WaitGroup | ||
| for { |
There was a problem hiding this comment.
Please could you break this nested code into functions?
cizmazia
reviewed
May 26, 2020
| }() | ||
|
|
||
| var wg sync.WaitGroup | ||
| for { |
There was a problem hiding this comment.
Would be nice to have this broken down to multiple functions.
cizmazia
reviewed
May 27, 2020
| // max block size is 3bytes: https://tools.ietf.org/html/rfc7959#section-2.1 | ||
| maxBlockValue = 0xffffff | ||
| // maxBlockNumber is 20bits (NUM) | ||
| maxBlockNumber = 0xffff7 |
There was a problem hiding this comment.
maxBlockNumber was 1048575 == 0xFFFFF not 0xffff7
There was a problem hiding this comment.
there was a bug - the max block number can have 20bits (0xffff7)
cizmazia
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.