fix: Utilize hoplimit for multicast #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkralik
force-pushed
the
jkralik/fix/mcast-hop-limit
branch
from
7224ca0 to
6d4d0c2
Compare
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
==========================================
+ Coverage 65.37% 65.40% +0.02%
==========================================
Files 79 79
Lines 5482 5498 +16
==========================================
+ Hits 3584 3596 +12
- Misses 1473 1475 +2
- Partials 425 427 +2
|
If the hoplimit is set, it will be used. If not set, the default values defined in the [OCF Core Specification](https://openconnectivity.org/specs/OCF_Core_Specification.pdf) section 12.2.9 will be used. Default values: - For "224.0.1.187:5683", the hoplimit is set to 1. - For "[ff02::158]:5683", the hoplimit is set to 1. - For "[ff03::158]:5683", the hoplimit is set to 255. - For "[ff05::158]:5683", the hoplimit is set to 255.
jkralik
force-pushed
the
jkralik/fix/mcast-hop-limit
branch
from
6d4d0c2 to
d90a598
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Danielius1922
approved these changes
Oct 10, 2023
|
@jkralik Review the Security Hotspots reported by SC, I think we can mark them as safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the hoplimit is set, it will be used. If not set, the default values defined in the OCF Core Specification section 12.2.9 will be used.
Default values: