Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate ETag into GetResource calls #367

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Integrate ETag into GetResource calls #367

merged 3 commits into from
Aug 9, 2023

Conversation

Danielius1922
Copy link
Member

  • enable to set the CoAP ETag option
  • return ETag for CONTENT response
  • add test

@Danielius1922 Danielius1922 requested a review from jkralik July 26, 2023 15:18
jkralik
jkralik reviewed Jul 26, 2023
View reviewed changes
jkralik
jkralik reviewed Jul 27, 2023
View reviewed changes
@Danielius1922 Danielius1922 force-pushed the adam/feature/etag branch 2 times, most recently from 81690c9 to 080a897 Compare July 31, 2023 16:18
@Danielius1922 Danielius1922 marked this pull request as ready for review August 1, 2023 14:17
@Danielius1922 Danielius1922 force-pushed the adam/feature/etag branch 2 times, most recently from 032719b to db0da48 Compare August 1, 2023 15:26
Danielius1922 and others added 2 commits August 3, 2023 20:36
@Danielius1922
Integrate ETag into GetResource calls
f22fbe2 
- enable to set the CoAP ETag option
- return ETag for CONTENT response
- add test
@jkralik @Danielius1922
resources: add etag to BatchRepresentation
c6b5b60
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023 •
edited
Loading

Codecov Report

Merging #367 (ecaa514) into main (60c77f6) will increase coverage by 0.14%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   65.16%   65.30%   +0.14%     
==========================================
  Files          77       78       +1     
  Lines        5408     5445      +37     
==========================================
+ Hits         3524     3556      +32     
- Misses       1461     1465       +4     
- Partials      423      424       +1
Files Changed Coverage Δ
pkg/codec/ocf/codec.go 58.62% <ø> (ø)
schema/resources/resources.go 70.00% <ø> (ø)
pkg/net/coap/client.go 70.14% <56.25%> (+0.38%) ⬆️
pkg/net/coap/response.go 82.35% <82.35%> (ø)
client/options.go 60.66% <100.00%> (+2.51%) ⬆️

jkralik
jkralik reviewed Aug 4, 2023
View reviewed changes
@Danielius1922
Upgrade dependencies
ecaa514 
Direct:
github.com/plgd-dev/go-coap/v3 v3.1.4
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@Danielius1922 Danielius1922 requested a review from jkralik August 8, 2023 14:52
@Danielius1922 Danielius1922 merged commit 7e698f6 into main Aug 9, 2023
@Danielius1922 Danielius1922 deleted the adam/feature/etag branch August 9, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkralik jkralik jkralik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Danielius1922 @codecov-commenter @jkralik