Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observerDevices: introduce failure threshold #341

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Feb 9, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #341 (c6a0d05) into main (cde25c5) will decrease coverage by 0.42%.
The diff coverage is 62.22%.

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   67.75%   67.33%   -0.42%     
==========================================
  Files          68       73       +5     
  Lines        4075     4458     +383     
==========================================
+ Hits         2761     3002     +241     
- Misses        941     1048     +107     
- Partials      373      408      +35     
Impacted Files Coverage Δ
client/initialization.go 32.50% <ø> (ø)
test/config.go 85.84% <ø> (ø)
...ecurity/generateCertificate/generateCertificate.go 47.69% <47.69%> (ø)
pkg/security/generateCertificate/config.go 48.59% <48.59%> (ø)
pkg/security/generateCertificate/generateRootCA.go 50.00% <50.00%> (ø)
client/observeDevices.go 68.04% <61.53%> (-1.23%) ⬇️
...rity/generateCertificate/generateIntermediateCA.go 65.71% <65.71%> (ø)
...generateCertificate/generateIdentityCertificate.go 70.37% <70.37%> (ø)
client/client.go 69.72% <88.15%> (+7.42%) ⬆️
client/core/getDevice.go 64.28% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jkralik jkralik force-pushed the jkralik/feature/observeDevicesFailureThreshold branch 2 times, most recently from c6a0d05 to 093bfd4 Compare February 9, 2023 13:15
@jkralik jkralik force-pushed the jkralik/feature/observeDevicesFailureThreshold branch from 093bfd4 to a944cb5 Compare February 9, 2023 13:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.8% 76.8% Coverage
0.0% 0.0% Duplication

@jkralik jkralik marked this pull request as ready for review February 9, 2023 14:46
@jkralik jkralik requested review from lubo-svk and Danielius1922 and removed request for lubo-svk February 9, 2023 14:46
@jkralik jkralik merged commit d35c4c8 into main Feb 10, 2023
@jkralik jkralik deleted the jkralik/feature/observeDevicesFailureThreshold branch February 10, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants