Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getDeviceByMulticast: set deviceID as di query parameter to mcast request #339

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Feb 6, 2023

No description provided.

@jkralik jkralik requested a review from Danielius1922 February 6, 2023 09:04
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #339 (c6c7fb5) into main (cb0d7ca) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   67.02%   67.04%   +0.02%     
==========================================
  Files          73       73              
  Lines        4397     4403       +6     
==========================================
+ Hits         2947     2952       +5     
- Misses       1041     1042       +1     
  Partials      409      409              
Impacted Files Coverage Δ
client/core/getDevice.go 64.28% <100.00%> (ø)
pkg/net/coap/client.go 73.91% <100.00%> (+0.57%) ⬆️
client/core/logger.go 20.00% <0.00%> (-10.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jkralik jkralik merged commit e481fbc into main Feb 6, 2023
@jkralik jkralik deleted the jkralik/getDeviceByID branch February 6, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants