Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coap-gateway: fix loss of order of messages #333

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Jan 21, 2023

using goPool causes loss of order of messages. For example coap notfications comes in order, but goroutines from gopool are executed underministic.

  • WithGoPool was removed
  • WithProcessReceivedMessageFunc to modify core cc.ProcessReceivedMessage

using goPool causes loss of order of messages. For example
coap notfications comes in order, but goroutines from gopool
are executed underministic.

- WithGoPool was removed
- WithProcessReceivedMessageFunc to modify core cc.ProcessReceivedMessage
@codecov-commenter
Copy link

Codecov Report

Merging #333 (647c7fc) into main (cde25c5) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   67.75%   67.82%   +0.06%     
==========================================
  Files          68       68              
  Lines        4075     4093      +18     
==========================================
+ Hits         2761     2776      +15     
- Misses        941      942       +1     
- Partials      373      375       +2     
Impacted Files Coverage Δ
client/getResource.go 100.00% <0.00%> (ø)
client/createResource.go 100.00% <0.00%> (ø)
client/updateResource.go 100.00% <0.00%> (ø)
client/core/getDevices.go 50.00% <0.00%> (+2.94%) ⬆️
client/core/observeResource.go 67.85% <0.00%> (+3.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jkralik jkralik marked this pull request as ready for review January 25, 2023 13:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jkralik jkralik merged commit fcbaba2 into main Jan 25, 2023
@jkralik jkralik deleted the jkralik/fix/loss-of-order-of-messages branch January 25, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants