Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix of exhausting CPU when observe devices is used (#325) #326

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Dec 19, 2022

No description provided.

@jkralik jkralik marked this pull request as ready for review December 19, 2022 07:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #326 (5e50c8f) into main (16146ad) will decrease coverage by 0.06%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   67.67%   67.61%   -0.07%     
==========================================
  Files          68       68              
  Lines        4074     4063      -11     
==========================================
- Hits         2757     2747      -10     
- Misses        940      942       +2     
+ Partials      377      374       -3     
Impacted Files Coverage Δ
client/getDevice.go 75.18% <80.00%> (+2.66%) ⬆️
client/observeDevices.go 69.27% <100.00%> (ø)
client/core/logger.go 20.00% <0.00%> (-10.00%) ⬇️
client/core/observeResource.go 64.83% <0.00%> (-3.03%) ⬇️
client/core/getDevice.go 63.09% <0.00%> (-1.20%) ⬇️
client/getResource.go 100.00% <0.00%> (ø)
client/createResource.go 100.00% <0.00%> (ø)
client/core/sdkError.go 43.47% <0.00%> (+2.93%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jkralik jkralik requested a review from der-dano December 19, 2022 07:24
@jkralik jkralik merged commit 68ae442 into main Dec 19, 2022
@jkralik jkralik deleted the jkralik/fix/exhaustingCPU branch December 19, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants