Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicity of devices found by IP #301

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Oct 14, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #301 (fd8df94) into main (17bd299) will decrease coverage by 0.27%.
The diff coverage is 57.37%.

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   62.95%   62.68%   -0.28%     
==========================================
  Files          65       65              
  Lines        4019     4022       +3     
==========================================
- Hits         2530     2521       -9     
- Misses       1135     1149      +14     
+ Partials      354      352       -2     
Impacted Files Coverage Δ
client/getDevice.go 63.88% <52.72%> (-11.67%) ⬇️
client/deviceCache.go 84.95% <100.00%> (+3.44%) ⬆️
client/deviceOwnershipSDK.go 50.00% <0.00%> (-4.77%) ⬇️
client/onboardDevice.go 71.66% <0.00%> (-2.34%) ⬇️
client/core/device.go 65.21% <0.00%> (-2.18%) ⬇️
client/getResource.go 100.00% <0.00%> (ø)
client/core/client.go 87.67% <0.00%> (+4.10%) ⬆️
client/maitenance.go 50.00% <0.00%> (+4.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jkralik jkralik force-pushed the jkralik/fix/removeDuplicitDeviceByFoundIP branch 4 times, most recently from 9893915 to 2c40ad7 Compare October 14, 2022 10:03
@jkralik jkralik force-pushed the jkralik/fix/removeDuplicitDeviceByFoundIP branch from 2c40ad7 to c4fd90b Compare October 14, 2022 10:04
@jkralik jkralik requested a review from lubo-svk October 14, 2022 10:05
@jkralik jkralik marked this pull request as ready for review October 14, 2022 10:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.6% 80.6% Coverage
0.0% 0.0% Duplication

@jkralik jkralik merged commit 46425fe into main Oct 14, 2022
@jkralik jkralik deleted the jkralik/fix/removeDuplicitDeviceByFoundIP branch October 14, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants