Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove refcounter from cache #292

Merged
merged 6 commits into from
Oct 6, 2022

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Oct 5, 2022

No description provided.

@jkralik jkralik requested a review from lubo-svk October 5, 2022 11:36
@jkralik jkralik force-pushed the jkralik/feature/removeRefCounter branch from 8f36c14 to f78f0cb Compare October 5, 2022 12:01
@jkralik jkralik force-pushed the jkralik/feature/removeRefCounter branch from f78f0cb to 9c3848b Compare October 5, 2022 12:04
@jkralik jkralik marked this pull request as ready for review October 5, 2022 12:10
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #292 (0102f98) into feature/refactore-caches (28bff42) will decrease coverage by 1.08%.
The diff coverage is 76.82%.

@@                     Coverage Diff                      @@
##           feature/refactore-caches     #292      +/-   ##
============================================================
- Coverage                     63.55%   62.46%   -1.09%     
============================================================
  Files                            65       65              
  Lines                          4061     4039      -22     
============================================================
- Hits                           2581     2523      -58     
- Misses                         1125     1158      +33     
- Partials                        355      358       +3     
Impacted Files Coverage Δ
client/refDevice.go 0.00% <0.00%> (-88.24%) ⬇️
client/ownDevice.go 39.02% <30.00%> (-1.89%) ⬇️
client/maitenance.go 40.00% <50.00%> (-6.16%) ⬇️
client/getDevices.go 67.97% <60.00%> (+3.47%) ⬆️
client/deleteDevice.go 75.00% <75.00%> (ø)
client/getDevice.go 71.11% <78.37%> (+0.35%) ⬆️
client/core/getEndpoints.go 85.71% <83.33%> (-14.29%) ⬇️
client/deviceCache.go 85.57% <85.57%> (ø)
client/core/device.go 67.39% <89.47%> (+0.72%) ⬆️
client/observeResource.go 65.34% <90.00%> (-1.33%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jkralik jkralik force-pushed the jkralik/feature/removeRefCounter branch from cda8986 to 19d575b Compare October 5, 2022 12:23
@jkralik jkralik force-pushed the jkralik/feature/removeRefCounter branch from fb0ed30 to 166ec97 Compare October 6, 2022 07:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

76.5% 76.5% Coverage
0.0% 0.0% Duplication

@jkralik jkralik merged commit 52fd1c6 into feature/refactore-caches Oct 6, 2022
@jkralik jkralik deleted the jkralik/feature/removeRefCounter branch October 6, 2022 09:29
jkralik added a commit that referenced this pull request Oct 6, 2022
* remove refcounter from cache
* update github.com/pion/dtls/v2 v2.1.6-0.20221001075407-984d41b9981a
jkralik pushed a commit that referenced this pull request Oct 6, 2022
* remove refcounter from cache
* update github.com/pion/dtls/v2 v2.1.6-0.20221001075407-984d41b9981a
* update github.com/plgd-dev/go-coap/v2 v2.6.1-0.20221004143021-7f33ba0d1b88
jkralik pushed a commit that referenced this pull request Oct 6, 2022
* remove refcounter from cache
* update github.com/pion/dtls/v2 v2.1.6-0.20221001075407-984d41b9981a
* update github.com/plgd-dev/go-coap/v2 v2.6.1-0.20221004143021-7f33ba0d1b88
jkralik added a commit that referenced this pull request Oct 11, 2022
* Upgrade dependencies

Direct:
github.com/plgd-dev/go-coap/v2 v2.6.1-0.20221005134509-88765211a3e9
golang.org/x/sync v0.0.0-20220929204114-8fcdb60fdcc0

Indirect:
golang.org/x/crypto v0.0.0-20221005025214-4161e89ecf1b
golang.org/x/exp v0.0.0-20221004215720-b9f4876ce741
golang.org/x/net v0.0.0-20221004154528-8021a29435af
golang.org/x/sys v0.0.0-20220928140112-f11e5e49a4ec
google.golang.org/genproto v0.0.0-20220930163606-c98284e70a91

* Minor stylistic fixes reported by stylecheck linter

* Lubo svk/feature/observe device by ip (#288)

Observe devices found by IP

Co-authored-by: Lubomir Capucha <lubomir.capucha@kistler.com>

* Refactore device cache (#292)

* remove refcounter from cache
* update github.com/pion/dtls/v2 v2.1.6-0.20221001075407-984d41b9981a
* update github.com/plgd-dev/go-coap/v2 v2.6.1-0.20221004143021-7f33ba0d1b88

* fix DeviceCache for infinite expiration

* replace ErrFunc by logger

* unify cloud.ResourceType and cloud.ResourceURI

* introduce nil logger

* allow golang 1.18+

* remove all device observers with emit notification when device is closed (#295)

* remove all device observers with emit notification when device is closed

* fix for CR

* use proper handler in observeDeviceResources

* update github.com/plgd-dev/go-coap/v3 v3.0.0

Co-authored-by: Daniel Adam <daniel.adam1922@protonmail.com>
Co-authored-by: lubo-svk <49922839+lubo-svk@users.noreply.github.com>
Co-authored-by: Lubomir Capucha <lubomir.capucha@kistler.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants