Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarCloud: add tests to increase code coverage #285

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

Danielius1922
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Merging #285 (93481ca) into main (cd4f25b) will increase coverage by 2.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
+ Coverage   60.24%   62.30%   +2.06%     
==========================================
  Files          64       64              
  Lines        4075     4062      -13     
==========================================
+ Hits         2455     2531      +76     
+ Misses       1261     1171      -90     
- Partials      359      360       +1     
Impacted Files Coverage Δ
schema/credential/credential.go 50.00% <100.00%> (+50.00%) ⬆️
schema/pstat/pstat.go 100.00% <100.00%> (+95.34%) ⬆️
client/offboardDevice.go 60.00% <0.00%> (-11.43%) ⬇️
client/core/maintenance.go 59.25% <0.00%> (-11.12%) ⬇️
client/observeDevices.go 66.41% <0.00%> (-1.64%) ⬇️
schema/acl/acl.go 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Danielius1922 Danielius1922 force-pushed the adam/feature/sonar-cloud-fixes-3 branch 2 times, most recently from 93481ca to 6829ef2 Compare September 19, 2022 15:20
@Danielius1922 Danielius1922 force-pushed the adam/feature/sonar-cloud-fixes-3 branch from 6829ef2 to ff62ec4 Compare September 19, 2022 15:37
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

42.1% 42.1% Coverage
0.0% 0.0% Duplication

@Danielius1922 Danielius1922 marked this pull request as ready for review September 19, 2022 16:01
@Danielius1922 Danielius1922 merged commit deb63e0 into main Sep 19, 2022
@Danielius1922 Danielius1922 deleted the adam/feature/sonar-cloud-fixes-3 branch September 19, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants