Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose discovery configuration #28

Merged
merged 2 commits into from
Sep 4, 2019
Merged

expose discovery configuration #28

merged 2 commits into from
Sep 4, 2019

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Sep 4, 2019

No description provided.

@jkralik jkralik requested a review from cizmazia September 4, 2019 12:51
@codecov-io
Copy link

codecov-io commented Sep 4, 2019

Codecov Report

Merging #28 into master will increase coverage by 3.29%.
The diff coverage is 92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   52.12%   55.42%   +3.29%     
==========================================
  Files          18       18              
  Lines        1034     1032       -2     
==========================================
+ Hits          539      572      +33     
+ Misses        404      369      -35     
  Partials       91       91
Impacted Files Coverage Δ
local/getOwnership.go 66.66% <100%> (ø) ⬆️
local/getDevice.go 61.9% <100%> (+3.69%) ⬆️
local/discover.go 71.42% <100%> (-8.17%) ⬇️
local/getResourceLinks.go 75.53% <100%> (+36.17%) ⬆️
local/getDevices.go 62.16% <100%> (+6.06%) ⬆️
local/device.go 73.14% <100%> (+1.18%) ⬆️
local/client.go 53.93% <63.63%> (-2.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9241fa...8c994ec. Read the comment docs.

@jkralik jkralik merged commit 13cf87f into master Sep 4, 2019
@jkralik jkralik deleted the exposeDiscoveryCfg branch September 4, 2019 14:01
@jkralik jkralik restored the exposeDiscoveryCfg branch September 4, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants