core: dont close connection when it is currently used #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,6 +50,63 @@ type TLSConfig struct { | |||
| GetCertificateAuthorities GetCertificateAuthoritiesFunc | |||
| } | |||
|
|
|||
| type conn struct { | |||
| mutex *semaphore.Weighted | |||
| c atomic.Value // *coap.ClientCloseHandler | |||
There was a problem hiding this comment.
it's a bit unusual to have both an atomic variable and a synchronization primitive
There was a problem hiding this comment.
Mainly it is used for synchronize dial and remove call. Only one dial can be called to one endpoint. And if dial is progress then remove function do nothing.
Danielius1922
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.