Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getDevice, getDevices: report all devices - owned by someone else #255

Merged
merged 1 commit into from
May 26, 2022

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented May 26, 2022

No description provided.

@jkralik jkralik requested review from dan3051 and der-dano and removed request for dan3051 May 26, 2022 09:27
@jkralik jkralik force-pushed the jkralik/fix/reportAllDevices branch from 33e4b89 to babc4a0 Compare May 26, 2022 09:33
@jkralik jkralik force-pushed the jkralik/fix/reportAllDevices branch from babc4a0 to 2bc4926 Compare May 26, 2022 11:13
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

69.7% 69.7% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #255 (2bc4926) into main (0d9c1c1) will decrease coverage by 0.20%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   60.62%   60.41%   -0.21%     
==========================================
  Files          63       63              
  Lines        3992     4007      +15     
==========================================
+ Hits         2420     2421       +1     
- Misses       1236     1246      +10     
- Partials      336      340       +4     
Impacted Files Coverage Δ
client/getDevice.go 68.42% <60.00%> (-0.81%) ⬇️
client/getDevices.go 62.50% <63.33%> (-3.11%) ⬇️
client/core/maintenance.go 59.25% <0.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d9c1c1...2bc4926. Read the comment docs.

@jkralik jkralik merged commit 251c41e into main May 26, 2022
@jkralik jkralik deleted the jkralik/fix/reportAllDevices branch May 26, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants