Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: add missing error checks #248

Merged
merged 2 commits into from
May 20, 2022
Merged

Conversation

Danielius1922
Copy link
Member

No description provided.

@Danielius1922 Danielius1922 requested a review from jkralik April 7, 2022 14:09
@Danielius1922 Danielius1922 force-pushed the adam/feature/errcheck-3 branch from f0459c9 to 85cb67a Compare April 13, 2022 07:19
@Danielius1922 Danielius1922 force-pushed the adam/feature/errcheck-3 branch from 85cb67a to e7a47d5 Compare May 2, 2022 09:50
@Danielius1922 Danielius1922 force-pushed the adam/feature/errcheck-3 branch 2 times, most recently from 461547b to 5958260 Compare May 17, 2022 09:41
@Danielius1922 Danielius1922 force-pushed the adam/feature/errcheck-3 branch from 5958260 to 952d61b Compare May 17, 2022 09:49
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

61.3% 61.3% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #248 (952d61b) into main (6a5a663) will increase coverage by 0.10%.
The diff coverage is 55.26%.

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   60.59%   60.69%   +0.10%     
==========================================
  Files          63       63              
  Lines        3987     3987              
==========================================
+ Hits         2416     2420       +4     
+ Misses       1239     1232       -7     
- Partials      332      335       +3     
Impacted Files Coverage Δ
client/getDevices.go 65.60% <ø> (+2.02%) ⬆️
client/core/observeResource.go 53.92% <25.00%> (ø)
client/observeResource.go 65.57% <61.53%> (-1.29%) ⬇️
client/observeDeviceResources.go 65.04% <62.50%> (ø)
client/observeDevices.go 68.05% <62.50%> (ø)
client/refDevice.go 91.48% <100.00%> (ø)
client/core/disownDevice.go 75.75% <0.00%> (+3.03%) ⬆️
client/core/maintenance.go 70.37% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a5a663...952d61b. Read the comment docs.

@Danielius1922 Danielius1922 merged commit b13ae20 into main May 20, 2022
@Danielius1922 Danielius1922 deleted the adam/feature/errcheck-3 branch May 20, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants