Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow set discovery configuration for commands #233

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Jan 17, 2022

No description provided.

@jkralik jkralik force-pushed the jkralik/update/go-coap branch from c62c33b to ec3437e Compare January 18, 2022 07:12
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #233 (939b8c3) into main (b5247ab) will increase coverage by 0.49%.
The diff coverage is 76.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   60.50%   61.00%   +0.49%     
==========================================
  Files          63       63              
  Lines        3844     3888      +44     
==========================================
+ Hits         2326     2372      +46     
  Misses       1201     1201              
+ Partials      317      315       -2     
Impacted Files Coverage Δ
client/client.go 61.20% <ø> (ø)
client/core/client.go 94.11% <ø> (ø)
client/deviceOwnershipBackend.go 0.00% <0.00%> (ø)
client/deviceOwnershipNone.go 0.00% <0.00%> (ø)
client/maitenance.go 50.00% <50.00%> (ø)
client/ownDevice.go 40.90% <50.00%> (+4.32%) ⬆️
client/options.go 50.86% <72.72%> (+14.90%) ⬆️
client/core/discover.go 77.77% <100.00%> (+0.27%) ⬆️
client/createResource.go 100.00% <100.00%> (+12.50%) ⬆️
client/deleteResource.go 100.00% <100.00%> (+15.38%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5247ab...939b8c3. Read the comment docs.

@jkralik jkralik force-pushed the jkralik/update/go-coap branch 2 times, most recently from 7c010d1 to 345276d Compare January 18, 2022 07:43
@jkralik jkralik changed the title test go-coap allow set discovery configuration for commands Jan 18, 2022
@jkralik jkralik requested a review from Danielius1922 January 18, 2022 07:44
@jkralik jkralik marked this pull request as ready for review January 18, 2022 07:45
@jkralik jkralik force-pushed the jkralik/update/go-coap branch 3 times, most recently from 6eaefb7 to 4e9f0d1 Compare January 18, 2022 08:23
update github.com/plgd-dev/go-coap/v2 for any cast discovery
@jkralik jkralik force-pushed the jkralik/update/go-coap branch from 2c51cca to 939b8c3 Compare January 18, 2022 10:45
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.9% 76.9% Coverage
0.0% 0.0% Duplication

@jkralik jkralik merged commit c49d131 into main Jan 18, 2022
@jkralik jkralik deleted the jkralik/update/go-coap branch January 18, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants