Update pion/dtls to master #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkralik
changed the title
jkralik
force-pushed
the
updateToPionDTLSmaster
branch
from
c251074 to
d7a6d5f
Compare
jkralik
requested review from
ondrejtomcik and
rafajpet
and removed request for
ondrejtomcik
jkralik
changed the title
jkralik
force-pushed
the
updateToPionDTLSmaster
branch
from
4a52612 to
7c55e0c
Compare
der-dano
reviewed
Feb 1, 2021
| // Decrypt decrypts a single TLS RecordLayer | ||
| func (c *TLSAecdhAes128Sha256) Decrypt(raw []byte) ([]byte, error) { | ||
| cbc := c.cbc.Load() | ||
| if cbc == nil { // !c.isInitialized() |
There was a problem hiding this comment.
Stale piece of code. Or is it meant to replace cbc == nil? Such check is done in Encrypt() as well. Please verify.
der-dano
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifying if github.com/pion/dtls/v2@issue-337-next works with iotivity-lite