Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactore update and observe resource #14

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Jun 17, 2019

No description provided.

@jkralik jkralik requested a review from cizmazia June 17, 2019 13:33
@jkralik jkralik force-pushed the refactoreObserveUpdate branch from 5ec1f1a to 448c48a Compare June 17, 2019 13:43
@codecov-io
Copy link

Codecov Report

Merging #14 into master will increase coverage by 1.32%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   48.82%   50.15%   +1.32%     
==========================================
  Files          14       14              
  Lines         680      658      -22     
==========================================
- Hits          332      330       -2     
+ Misses        287      271      -16     
+ Partials       61       57       -4
Impacted Files Coverage Δ
local/observeResource.go 0% <0%> (ø) ⬆️
local/getResource.go 77.77% <100%> (+20.63%) ⬆️
local/updateResource.go 77.77% <100%> (+39.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c55d23...448c48a. Read the comment docs.

@jkralik jkralik merged commit 7fc7284 into master Jun 17, 2019
@jkralik jkralik deleted the refactoreObserveUpdate branch June 17, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants