Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@tetarchus
Copy link
Contributor

@tetarchus tetarchus commented Jun 2, 2022

Upgrades to Jest 28 and fixes any test/type errors that came up.

I don't use this package directly, only through a third party library so have been unable to test in use, but all tests are successfully passing.

Please let me know if any edits need to be made, or if anything isn't working when testing in an actual use-case.

Should fix #796

@coveralls
Copy link

coveralls commented Jun 2, 2022

Pull Request Test Coverage Report for Build 2431421466

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.226%

Totals Coverage Status
Change from base Build 2387719391: 0.0%
Covered Lines: 106
Relevant Lines: 109

💛 - Coveralls

"jest-circus": "^26.6.3 || ^27.0.0",
"jest-environment-node": "^26.6.2 || ^27.0.0",
"jest-runner": "^26.6.3 || ^27.0.0"
"jest": "^26.6.3 || ^27.0.0 || ^28.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean after this change we are still compatible with jest 26 and 27?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tetarchus , thank you for making this PR, as we're currently blocked from upgrading jest. Do you know if this is the case?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because if it means we are not compatible with <28 then we need to release it as a major change, otherwise just as a minor version bump.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could imagine that this is full of breaking changes, as it's mentioned in the Jest 28 post that the "list of breaking changes is long". https://jestjs.io/blog/2022/04/25/jest-28

tetarchus added 2 commits June 3, 2022 00:01
- Should now work with the existing (26/27)
versions and the latest version (28)
@tetarchus tetarchus requested a review from mxschmitt June 8, 2022 10:35
@HarelM
Copy link

HarelM commented Jun 23, 2022

Any news about this?
I would love to move forward to jest 28 and I believe this will help me so...

@syntactic-salt
Copy link

Any plan to move forward with this upgrade?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Jest 28

6 participants