Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@mmarkelov
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented May 26, 2021

Pull Request Test Coverage Report for Build 878393062

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.798%

Totals Coverage Status
Change from base Build 870713098: 0.0%
Covered Lines: 106
Relevant Lines: 109

💛 - Coveralls

@mmarkelov mmarkelov marked this pull request as ready for review May 26, 2021 11:51
@mmarkelov mmarkelov requested a review from mxschmitt as a code owner May 26, 2021 11:51
@mmarkelov mmarkelov merged commit 2da178f into master May 26, 2021
@mmarkelov mmarkelov deleted the Bump-jest branch May 26, 2021 17:30
"jest": ">=26.6.3",
"jest-circus": ">=26.6.3",
"jest-environment-node": ">=26.6.2",
"jest-runner": ">=26.6.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these, at least jest-runner, really be set to >=27.0.0? If users now use Jest 26 and don't set e.g. "testRunner": "jest-circus/runner" themselves, it means many of the things in the environment such as handleTestEvent will not work, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhildenbiddle I suppose that it should be work with Jest 26, but only if you set "testRunner": "jest-circus/runner" manually. But i need to check this. And put it in documentation. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants